Senior-Level Code Review & Refactor Plan

How to use

1. Replace {{programming_language}} with the language of your code (e.g. Python, JavaScript, Go).
2. Paste the specific function or module you want reviewed into {{code_block}} — keep it focused rather than pasting an entire large file.
3. Read through the review in order; correctness and security issues should be fixed before performance or style issues.
4. Apply the top 2 corrected snippets first, then address the remaining items in the prioritized list.

Example input

Act as a senior software engineer... Code:
```python
def get_user(user_id):
    query = "SELECT * FROM users WHERE id = " + user_id
    result = db.execute(query)
    return result
```

Example output

1. Correctness — the function assumes user_id is always a valid, existing ID; no handling for a missing user, which will silently return an empty result rather than raising a clear error.
2. Security — this is a SQL injection vulnerability; user_id is concatenated directly into the query string instead of using parameterized queries.
3. Performance — SELECT * retrieves all columns even if only a subset is needed downstream, increasing payload size unnecessarily.
4. Maintainability — no type hints or docstring; unclear what 'result' returns (single row vs list).
5. Prioritized refactor plan: (1) Fix SQL injection via parameterized query [highest impact, low effort], (2) Add explicit not-found handling, (3) Select only needed columns, (4) Add type hints and docstring, (5) Add unit test for missing user case.
Corrected code:
```python
def get_user(user_id: int) -> dict | None:
    query = "SELECT id, name, email FROM users WHERE id = %s"
    result = db.execute(query, (user_id,))
    return result[0] if result else None
```

Customization tips

• — Add context about the code's environment (e.g. 'this runs in a high-traffic production API') so performance and security assessments are calibrated correctly.
• — Ask for a stricter review if the code handles sensitive data (PII, payments, auth).
• — Request the review in a specific format (e.g. as inline comments) if you want to paste it directly into a pull request.

Tags

FAQ

Related Skills

Related Articles